Colton Allen

Results 9 comments of Colton Allen

@markstory Just so you're aware, the tests fails because I'm waiting on open pulls on the snuba repo. Once those are merged this can be merged too (assuming its approved)....

@markstory Tests passing. Let me know if you have any more reviews.

Can someone explain to me how this change increases the bundle size by 12 bytes?

@anonrig My big fear is this: > due to the lack of coverage in specific areas, it didn't get caught in the CI. To compensate we should focus on changing...

This is a functioning partial implementation of the idea. https://github.com/getsentry/sentry/blob/replays-use-run-task-strategy/src/sentry/replays/consumers/recording/factory.py ```python return Pipeline( steps=[ # Catch and log any exceptions that occur during processing. Partial(LogExceptionStep, message="Invalid recording specified."), # Deserialize...

@untitaker I adopted the existing formula and eventually the consumer was so simplified that the pipeline concept was not needed.

@untitaker I have stopped pursuing this. In general the less code, frameworks, boilerplate, etc. to learn the better. I'd much rather duplicate simple work than have to learn highly abstracted...

I will look into this!

@bruno-garcia Billy's docs PR provides this information but its not merged.