Carl Lundin

Results 28 comments of Carl Lundin

Hey @IslandJohn, Thank you for the detailed and high effort investigation. Can you provide detailed reproduction steps for this issue? Either a bash or python script would be very useful...

I did not discover any particular reason this is being done after digging in the git history. There seems to be an inconsistency with how `strptime` is beiing used. ```sh...

Sorry for the delay. Picking this back up. Here is a simple script for a repro. ``` from google.auth import default from google.auth.transport.requests import Request from google.oauth2 import credentials orig_cred,...

Following up with a simple repro that is more accurate to the reported symptoms. ``` ➜ bat repro.py ───────┬─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────── │ File: repro.py ───────┼─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────── 1 │ from google.auth import default 2...

Okay. Digging in further and I do not believe this is the cause of your issue. While I do believe the code should be cleaned up, and not strip the...

@mgorny Thank you for this change. The contents look correct. It seems the lint check is failing, so please run `nox -s blacken` to fix the formatting issues, and push...

Hi @wj-chen, can you provide more details for this feature request? The oauth2 Credential [object](https://github.com/googleapis/google-auth-library-python/blob/b5a3929144589f1d47f91384aa1451147fb8a975/google/oauth2/credentials.py#L442) has a `to_json` feature. What are the other gaps that you would like to see...

Thank you for the contribution! It will take some time to accept this patch. There are downstream dependencies that depend on this functionality.

Hi @pquentin, We use PyOpenSSL to implement non-file based credentials w/ mTLS. We are investigating other approaches but until we have a solution in place we cannot migrate. Deprecation notice...

@danigm Let me double check. My assumption is that we do not want the deprecation warning to propagate. I appreciate the effort / time to update this for us!