Meir Tseitlin

Results 46 comments of Meir Tseitlin

Anything new with this? Thanks

@mosquito - any chance to merge it? Thanks

There were no tests for JsonRPC I think

I am working on tests and the following code reproduces the error: ``` def rpc_func(*, foo, bar): assert not foo assert not bar return {"foo": "bar"} async def test_jsonrpc_simple(self, channel:...

Everything fixed (including exception handling) and tests are added.

@mosquito, what do you think is wrong? The tests I added reproduce the problem in the original code and it works with the fix. @decaz, what do you think?

@mosquito - fixed, sorry. Please run the workflow. Also added proper documentation here - https://github.com/mosquito/aio-pika/issues/425

@mosquito - Are you open to consider this version of `deserialize`? ``` def deserialize(self, data: Any) -> bytes: res = RPC.deserialize(self, data) if isinstance(res, dict) and "error" in res: cls...