aio-pika icon indicating copy to clipboard operation
aio-pika copied to clipboard

Published 20 hours ago • verified publisher icon mosquito

new: add custom exchanges to rpc pattern

Open cloud-rocket opened this issue 3 years ago • 6 comments

Extended RPC pattern to include support for custom exchanges.

This is needed when creating multiple micro-services operated via similar API

cloud-rocket avatar Feb 12 '21 18:02 cloud-rocket

@mosquito, what do you think?

I haven't added anything related to py35/py36 errors

cloud-rocket avatar Feb 22 '21 20:02 cloud-rocket

@cloud-rocket please rebase against the master branch

mosquito avatar Feb 22 '21 20:02 mosquito

@mosquito,

@cloud-rocket please rebase against the master branch

done

cloud-rocket avatar Feb 22 '21 21:02 cloud-rocket

@mosquito ping

cloud-rocket avatar Mar 01 '21 18:03 cloud-rocket

Anything new with this?

Thanks

cloud-rocket avatar Mar 08 '21 17:03 cloud-rocket

@mosquito - any chance to merge it?

Thanks

cloud-rocket avatar Apr 27 '21 19:04 cloud-rocket

@mosquito , it's been a while, if I will rebase this PR to the recent version, would you be able to merge it this time?

Thanks

cloud-rocket avatar Aug 21 '23 23:08 cloud-rocket

@cloud-rocket please rebase it against master branch

mosquito avatar Aug 22 '23 07:08 mosquito

Sorry, miss clicked

mosquito avatar Aug 22 '23 07:08 mosquito

@mosquito - rebased from latest master.

Please review

cloud-rocket avatar Aug 28 '23 18:08 cloud-rocket

Coverage Status

coverage: 88.402% (+0.2%) from 88.246% when pulling 62a32681e28600f82e8bc20d9873c6fe8e88355a on cloud-rocket:add-custom-rpc-exchange into c8dae1ec2431a914ddec25032de95a2542978041 on mosquito:master.

coveralls avatar Aug 28 '23 18:08 coveralls

@mosquito - I fixed the type / styling issues. Please rerun the tests

cloud-rocket avatar Aug 29 '23 13:08 cloud-rocket

@mosquito - fixed the poetry also and tried locally (sorry, missed it 1st time). Please rerun the CI

cloud-rocket avatar Aug 29 '23 15:08 cloud-rocket

@mosquito, ping! Can please rerun the pipeline! Thank you!

cloud-rocket avatar Aug 30 '23 14:08 cloud-rocket

I will review it on weekends. Busy right now.

mosquito avatar Aug 30 '23 14:08 mosquito

@mosquito, I am planning to release an open-source micro-service communication and orchestration library which needs this feature. Would be great to have it merged. It is pending for 1.5 years now!

Thank you!

cloud-rocket avatar Sep 05 '23 13:09 cloud-rocket

@mosquito - can you please review the update following your comment? Thanks

cloud-rocket avatar Sep 11 '23 16:09 cloud-rocket

@mosquito - it would be great if you could make it happen, it's a small change and I'd really like to publish another package based on it.

Thank you

cloud-rocket avatar Sep 15 '23 15:09 cloud-rocket

Hi @mosquito - can you please pull this in? Thanks!

cloud-rocket avatar Sep 18 '23 20:09 cloud-rocket

@mosquito, I cannot publish the dependent package to the public Pypi before this PR is merged. Would appreciate your help on this. Thanks!

cloud-rocket avatar Sep 20 '23 13:09 cloud-rocket

@cloud-rocket sorry for delay, a new version 9.3.0 has been released with your changes

mosquito avatar Sep 20 '23 13:09 mosquito

@mosquito, Thanks! FYI - the microservice orchestration package based on aio-pika - https://github.com/imubit/amqp-fabric

cloud-rocket avatar Sep 20 '23 15:09 cloud-rocket