aio-pika
aio-pika copied to clipboard
new: add custom exchanges to rpc pattern
Extended RPC pattern to include support for custom exchanges.
This is needed when creating multiple micro-services operated via similar API
@mosquito, what do you think?
I haven't added anything related to py35/py36 errors
@cloud-rocket please rebase against the master branch
@mosquito,
@cloud-rocket please rebase against the master branch
done
@mosquito ping
Anything new with this?
Thanks
@mosquito - any chance to merge it?
Thanks
@mosquito , it's been a while, if I will rebase this PR to the recent version, would you be able to merge it this time?
Thanks
@cloud-rocket please rebase it against master branch
Sorry, miss clicked
@mosquito - rebased from latest master.
Please review
coverage: 88.402% (+0.2%) from 88.246% when pulling 62a32681e28600f82e8bc20d9873c6fe8e88355a on cloud-rocket:add-custom-rpc-exchange into c8dae1ec2431a914ddec25032de95a2542978041 on mosquito:master.
@mosquito - I fixed the type / styling issues. Please rerun the tests
@mosquito - fixed the poetry
also and tried locally (sorry, missed it 1st time). Please rerun the CI
@mosquito, ping! Can please rerun the pipeline! Thank you!
I will review it on weekends. Busy right now.
@mosquito, I am planning to release an open-source micro-service communication and orchestration library which needs this feature. Would be great to have it merged. It is pending for 1.5 years now!
Thank you!
@mosquito - can you please review the update following your comment? Thanks
@mosquito - it would be great if you could make it happen, it's a small change and I'd really like to publish another package based on it.
Thank you
Hi @mosquito - can you please pull this in? Thanks!
@mosquito, I cannot publish the dependent package to the public Pypi before this PR is merged. Would appreciate your help on this. Thanks!
@cloud-rocket sorry for delay, a new version 9.3.0 has been released with your changes
@mosquito, Thanks! FYI - the microservice orchestration package based on aio-pika
- https://github.com/imubit/amqp-fabric