Folke Behrens

Results 20 comments of Folke Behrens

I can give it a try, but would have to wait until the weekend. I think it's safe to remove the entire object when there are no defined fields left,...

So I just looked at this. I see how the mentioned functions build the schemas for body properties. Now somehow both need to tell the caller that it must not...

I was thinking since it's not an error but a successful call it should not be an error (like `ErrEmptyObject`), but I also don't want the returned schema to be...

Hi! Sorry, is it too late to ask to turn all gauges into counter pairs? Metrics like `active_tasks_count` or `injection_queue_depth` are fast moving gauges and even taking a snapshot every...

I believe this was largely done by @nox in #565 a year ago. Anything missing? It looks like `h2::ext::Protocol` is not added as extension to the `Request`, at least I...

I added the following code to `server::Peer::convert_poll_message()` and that exposes the protocol as `Request` extension. This works for me. Not sure if this is the right place to do this,...

Great, thank you! I just created the first of at least two PRs (#224) which instruments some futures. Please have a look and see if you're okay with this. Maybe...

I need a bit more time working on the perf counters. In the meantime, it would be great if we could merge #230 and then publish a new release. Would...

Thanks a lot! I'll return soon once I have a good design for the perf counters. I'll also try to add a test tracing subscriber that can capture tracing events,...

If you want to print all SQL to stdout you can now use the tracing feature and the FmtSubscriber from https://docs.rs/tracing-subscriber/latest/tracing_subscriber/fmt/index.html to log queries. Make sure tracing level DEBUG is...