Patrick Cloke

That seems reasonable! Do you know if that's that usually how frameworks deal with this? It probably makes sense to not require the sites package anyway. Would you be able...

Another thought, would it make sense to get this from the adapter some-how? I'm unsure if it's useful anywhere else though.

> redirected to the setup two factor page, the token is always coming back invalid. If a user doesn't have two factor required but setups up the two factor, the...

The corresponding code is in https://github.com/percipient/django-allauth-2fa/blob/f2a2e77dcc93facd5885903acddfd23af3e53b99/allauth_2fa/forms.py#L41-L49 Does the user have multiple unconfirmed devices for some reason? Could be worth sub-classing that and poking a bit at the devices and such.

Please shout if you need help doing the release! I think I dropped what I used to do into an email, but to put it in public: > Unfortunately I...

Removing review since this depends on #401. If we want to merge this we'll need to dust that off first.

Is this an implementation issue (e.g. with sydent) or a spec problem or somewhere in-between?

FYI the graphs above seem based on the `sygnal_active_apns_requests` metric. It would be interesting to see the `sygnal_inflight_request_limit_drop` for the pushkin when this happens since it is *supposed* to be...

Can you provide more information about the version of Sygnal that's being run? Are there any errors in the Sygnal log?

I think this needs this code from Synapse ported to Sygnal: https://github.com/matrix-org/synapse/blob/15090de85075c9d7d54479b4bfd79057de64059b/synapse/http/__init__.py#L43-L54