Patrick Cloke comments

Results 340 comments of


                                            Patrick Cloke

let update_synapse_database run on a multi-database configurations

Putting this back in the queue since I've lost all state on it and likely won't get to it soon.

TypeError: argument must be an int, or have a fileno() method.

We're running celery 4.2.1 on billiard 3.6.0 and it works fine. 👍

TypeError: argument must be an int, or have a fileno() method.

@auvipy Not sure why you closed this, I was just responding to @paulocheque saying that you cannot use billiard 3.6.0 with celery 4.2.1. This seems like we should be updating...

Behavior of then() for a resolved promise?

> whats your current thoughts on this? My thought is that it is confusing that the callbacks never get called, but it is unclear what *should* happen. This package sadly...

"staff_member_required"-solution in documentation (section installation at the end) leads to error for non_staff members

I can't say I've run into this sorry!

U2F support

There's a `django-otp-yubikey` that would likely make this easy to integrate. Probably need to solve #23 first though.

"two-factor-authenticate" remains accessible in the middle of a login flow

Yes, that does seem pretty weird. I could think of a situation like the following: * User attempts to log-in with username/password. * User gets to the 2FA page and...

"two-factor-authenticate" remains accessible in the middle of a login flow

> Looking through `django-otp`, there's a `OTPAuthenticationFormMixin` in `forms` that could put everything on the login page and possibly fix this, but I'm at a loss as to where to...

Support more types of devices (besides just TOTP)

As the description said it would be nice if you could configure whatever you wanted and django-allauth-2fa just used it, instead of being hard-coded to assume TOTP is the only...

Documentation error which can cause TFA bypass

Thanks @pjensen000! Any chance you can provide this as a PR?