Patrick Cloke

Results 263 comments of Patrick Cloke

@gersh Shout when you think this is ready for review again! You should be able to run the lints locally manually by running the same commands as CI: https://github.com/clokep/celery-batches/blob/59cc04f9c0220581fd84a1116cd390ddc6a799ec/.github/workflows/main.yml#L23-L39

That seems like a bug -- we should probably schedule only an additional `flush_every` or something like that which have become available due to ETAs. (Taking care to then flush...

I'll double check next time I have a notification for a security advisory. 😄

Looking quickly at the code it looks like it will set it, but *only* if there are records to return. See: https://github.com/twisted/twisted/blob/fa4a4fb57028af27be01c3f5bebdc7e132be87bd/src/twisted/names/server.py#L227-L231 I'm unsure if this is correct behavior or...

> @clokep @Half-Shot : as authors, what's keeping this in draft? It feels ready for broader review/implementation. I think I was hoping @Half-Shot could fill in the impact on bridges...

Overall I'm happy with this, but I think the text is a bit confusing. @turt2live and I left a bunch of comments which should help with that. @mscbot concern General...

@deepbluev7 Thanks for your effort on clarifying and improving this MSC. I think it is much easier to read now and clearer what the proposed changes are! 🎉 @mscbot resolve...

Note that Synapse does not normally mark things as read if you send an event, i.e. https://github.com/matrix-org/synapse/issues/14837#issuecomment-1401922555...which doesn't match the spec (and it is confusing if it resets it here!)

> I ask because I have an existing OIDC auth system that is not on the same server as my homeserver, and without a token cache I don't want to...

@sandhose Would be the one who knows if there's a plan here, I think. We'll see what they say.