Patrick Cloke

Results 263 comments of Patrick Cloke

Thanks! Hopefully I'll have time to look at this soon. 👍

Oh, any idea on if we can write tests for this? I imagine it wouldn't be too bad, just enabling some signals and ensuring we receive them?

> HI @clokep , thanks for the package. You're welcome! > I'm interested to know a bit more about the `class SimpleRequest` . As mentioned in the doc string for...

> Currently I'm calling `request.send_event("task-succeeded", result=response)` after saving the request's result in the backend (i.e after mark_as_done). When you say "currently" are you using Celery batches now? > But I'm...

(I've also retitled this, hopefully it captures what you were going for.)

@srinivaas14 The Received and Started changes look pretty reasonable, I'm a bit more skeptical about the Success/Failure ones though since I don't think we require that any particular results be...

> Hi @clokep , thanks for the comments. > > > I'm a bit more skeptical about the Success/Failure ones though since I don't think we require that any particular...

Looks like we don't call into the chains (or groups) after a successful task run, this would need to port some of the code around https://github.com/celery/celery/blob/2411504f4164ac9acfa20007038d37591c6f57e5/celery/app/trace.py#L508-L516 This should be fairly...

> I'm trying to figure out how all of this works. Do I need to `apply_async` the next task from the chain inside `on_return` callback? If you're trying to modify...

There's a bit of a fan-in/fan-out question here. It isn't always clear what the different chains mean: * Normal -> Batch -> Normal * Call a task * Use the...