Patrick Cloke

In this case it seems like we could also try to fix the Twisted bug?

Do we want to put upgrade notes for this somewhere? It seems like it would mostly be copying out of the description. Probably in the `CHANGELOG.md` file directly?

I'm going to throw this back on the @matrix-org/synapse-core pile as I'm not sure I have enough context into how these keys are used to be confident in my review!

I'm removing review on this since it depends on #402, which is a sizeable PR.

I'm not sure if we mention a minimum Synapse version anywhere, but if we do we'll want to update it to whatever version added support to async/await in the media...

I think this is waiting on @Fizzadar, so I'm going to remove this from the review queue.

I've had this moved to the compress repo since it seems related to running that tool.

It was pointed out that this might be matrix-org/synapse#6779, which is then made worse by using the state compressor. Maybe the query in https://github.com/matrix-org/synapse/issues/6779#issuecomment-582851569 could be run to see if...

Hmm, I wonder if this doesn't work for any nullable field? Definitely seems like an oversight, thanks for the bug report! Do you have a fuller stack trace of the...

I think that code needs special handling for `null`, unfortunately not all databases order `null` the same way, but pretty much we would want to return `1` is `value1` is...