Cliff Hall

Results 176 comments of Cliff Hall

@msabramo Also, I noticed that running these tests created a lot of files locally in the project. Can these not be created in the system tmp folder? I realize the...

> I wonder if [1ff39f1](https://github.com/modelcontextprotocol/inspector/commit/1ff39f13f5339a1bf87101f80848bc7b69c089b4) caused something to trigger that asked a maintainer to approve execution? Nope. That's why I asked to remove it. It did not help, but could...

> Maybe once it gets merged, the comments will work on builds on `main` (probably not on PRs in forks, which is probably a good thing). Can you also remove...

One last question: Is there a way to get it to stop trying to make the PR comment? It's still reporting that it can't do it.

I re-ran the jobs just to see, and it does not produce the failed annotation warning now.

Thanks for hanging in there @msabramo.

Hi @max-stytch I tried testing with a schema based on the shape [you linked to](https://github.com/modelcontextprotocol/inspector/issues/332#issuecomment-2837264746) but when I click the Add Item button, it doesn't show a field like it...

@max-stytch I think there were some crossed wires here. @olaservo's comment that led you to close this I think was mistaken. This was about the form handling and #480 was...

> I was doing unrelated `inputSchema` investigation with a testing server and tool, and had taken note of this issue, so I checked the form rendering. I think the form...

@olaservo I agree that env vars should override defaults and query vars from the request should trump both. This seems correct. Maybe some videos of the tests for confidence?