Cliff Hall

Results 176 comments of Cliff Hall

@xiaoyijun Almost over the finish line.... but you're going to need to run `prettier-fix` to pass CI.

Question, @xiaoyijun could this also have a field for OAuth roles to ask for? We currently don't have a good solution for that. Definitely feel free to push back if...

> @cliffhall Thanks for bringing this up! I’m not very familiar with OAuth roles (since, as far as I know, roles are not defined as part of the OAuth specification)....

This is a double negative that made me have to think about its validity for a second. Could it instead be "Enable Browser Auto-open" and default to true?

> @cliffhall Review please @kawakamidev It works fine for opening, but the UI configuration field doesn't change the behavior. If I set it to false then close the inspector, when...

> @kawakamidev It works fine for opening, but the UI configuration field doesn't change the behavior. If I set it to false then close the inspector, when I run the...

> I started working on this. Hi @balajmarius! Any progress on this?

BTW, @max-stytch on this topic in Discord: > If we want to test _lack of conformance_ - e.g. if an AS does something wrong and we want to confirm the...

> Added `.github/workflows/e2e_tests.yml` (from @cliffhall) in [8a8212c](https://github.com/modelcontextprotocol/inspector/commit/8a8212c9ca420f998bfa9da3f3bde2e11f23bcbb). I guess a maintainer needs to approve the workflow to run so we can see how it works? @msabramo I tried but it...

@msabramo Failures when I run the tests locally with `/usr/local/bin/npm run test:e2e`. What am I missing?