Nick Galbreath

s3: Move AttemptStrategy into S3 object so callers can change, replace

4

Hi Hashicorp team. Thanks for all your projects and products. The hardwired default of S3 attempts is a bit problematic for me. In: ``` go // The S3 type encapsulates...

Much of the code uses `echo` as way of returning results or a partial result in a pipe. Other times echo is used as a logging mechanism, and inconsistently. Here...

I was able to commit non-formatted code accidentally. precommit should run shfmt and error on problems.

http_download missing unit tests

eg. https://github.com/square/notify has the license file one level down: https://github.com/square/notify/blob/master/schedule/LICENSE

The sort for by datacenter isn't stable. Entries with the same count may be in a different order for each run. Need to sort by count, by name

aspell ok! ``` echo " 1.23e10" | aspell -a @(#) International Ispell Version 3.1.20 (but really Aspell 0.60.6.1) * ``` hunspell tokenizes it as two words `1` and `23e10` ```...

Allow loading of multiple dictionaries. it's not clear how this works if different dictionaries use different `WORDCHAR` stanzas.

Currently, the AFF and DIC files are expected to be in UTF-8. Oddly the `en_US` AFF file is in UTF-8 but all other `en_` ones are in `ISO8859-1` The `SET`...

[en_US] apostrophes don't work as expected

1

Words like `don't` are processed as `don` + `t`