Nick Galbreath

Results 76 comments of Nick Galbreath

Fix for MySQL, MSSQL whitespace evasion

why are tests failing?

MSSQL non-ascii code in SQL

hello, thanks for you report. libinjection doesn't know about external encodings. base64, hex, query/url, html. You have to normalize it first before making the call.

false postive

Hi, i would remove the "nc" fingerprint to avoid these, or add your own heuristics here.

lua binding compile failed with lua5.3

patches welcome. Im not that familiar with LUA bindings, esp with 5.3 Recommend using luajit and/or lua 5.2

False positives

That is weird as it definitely should not be flagged and I'm unable to reproduce using the latest version. You got any more details? On Sat, Jun 7, 2014 at...

Integer overflow(hs.token_len)

hi thanks for the report. the XSS code has a number of these. Im working on cleaning it up. thanks for the test cast. That is helpful! On Jun 5,...

Folding difference with foo *** 1 and foo **** 1

good question! I will investigate! thanks for the report..　 and good to see you again! nickg On Mar 6, 2014, at 21:57, Kanatoko [email protected] wrote: > foo **\* 1 =>...

Consider moving text truncation tests to a separate test suite

e.g. AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAB was in tests/test-tokens-words-001.txt tests/test-tokens-string-002.txt

simplify public interface - replace *Entry with Interface in interface.go

failed to do golang stuff unrelated to the PR ``` # github.com/apex/log/handlers/delta handlers/delta/delta.go:140: time.Since(h.start).Round undefined (type time.Duration has no field or method Round) handlers/delta/delta.go:142: time.Since(h.start).Round undefined (type time.Duration has no...

simplify public interface - replace *Entry with Interface in interface.go

rocking. It's likely you'll want to do something a bit different, especially in tests with the casting. If v2 is on the table then, in my fantasy world, the Fielder...