Michi Hoffmann

Results 190 comments of Michi Hoffmann

@ste93cry Next time, please don’t update my branches without consulting me first. You are always welcome to branch off from my branch and propose your changes in a separate PR....

Nothing is wrong if people continue using `TransactionContext::fromSentryTrace`, if they don't want to use Dynamic Sampling. We will likely release this before Symfony and Laravel, so I rather not add...

https://docs.sentry.io/platforms/php/guides/laravel/usage/#capturing-errors Is this what you were looking for?

@flimzy We might want this to be its own module, to not add further deps to the main package. cc @kamilogorek What do you think?

btw, @flimzy test failures are caused by a new option added via https://github.com/getsentry/sentry-go/pull/490

Thanks, LGTM! About the modules topic: We will start to move our integrations into their own modules soon. While module pruning works well, I rather have a more concise `go.mod`...

We made the decision to tackle #649 after the release of DS.

Is there anything left to be done?

@stayallive Yep, I took a look and we have to fix up some stuff over at Symfony.

Thanks @dkarlovi. I got a bit side-tracked, so thanks for commenting!