Michi Hoffmann

Results 190 comments of Michi Hoffmann

You would need to create a source bundle and upload it at compile time. And then you would also need to upload debug files, which is odd in Go, that...

I filled part of this as https://github.com/getsentry/sentry/issues/59030 and pinged the PM involved. I totally agree btw, this is crazy bad! > Is this on the radar of the wider PM...

We did ship an update to our stack trace view, which now lets you map your stack trace to GitHub without the need for having source context availiable.

Does https://github.com/getsentry/sentry-go/pull/707 relate to this?

Yep, Windows tests are sadly a bit flaky 🙁 More tests are always welcome. I didn't look into how other SDKs handle this yet, did you maybe check https://github.com/getsentry/sentry-javascript already?

Sorry that it took us a while to get back to you. When using Otel, you shouldn't use any Sentry performance-related features. This is why we added the `instrumenter` option...

This is a good point about panic tracking I haven't thought about. IMO, we could wrap this code https://github.com/getsentry/sentry-go/blob/master/http/sentryhttp.go#L97-L112 into an if condition that checks for `ClientOptions.EnableTracing`, so no transactions...

Ok, we might need to add the `instrumenter` option to control the behaviour. If Otel is active, no transactions/spans should be created by the Sentry SDK.

We actually extract the Sentry trace header, see https://github.com/getsentry/sentry-go/blob/master/otel/propagator.go#L77-L95