Clément Péron

Results 100 comments of Clément Péron

> @clementperon Here are my thoughts: > > * This is a major breaking change because any project that uses PcapPlusPlus would need to adjust their `#include`. A solution could...

@Dimi1010 @seladb IMO it's easier to handle this on the user side based on the cmake version or PKG config version no ?

@Dimi1010 @seladb before breaking we can allow user to use both include style with this PR it will also fix my issue when Pcap++ is installed with Homebrew on MacOS...

@seladb Cmake can handle deb generation. I think this MR is a bit complicated and could be simplified using cmake deb packaging no ? See https://cmake.org/cmake/help/latest/cpack_gen/deb.html

> > @seladb Cmake can handle deb generation. I think this MR is a bit complicated and could be simplified using cmake deb packaging no ? See https://cmake.org/cmake/help/latest/cpack_gen/deb.html > >...

> > > > @seladb Cmake can handle deb generation. I think this MR is a bit complicated and could be simplified using cmake deb packaging no ? See https://cmake.org/cmake/help/latest/cpack_gen/deb.html...

@bhaskarbhar I have pushed on my repo an example but don't have time to properly test everything right now. https://github.com/clementperon/PcapPlusPlus/commits/master/

@seladb you can see the commit here https://github.com/clementperon/PcapPlusPlus/commit/bcf75779188692d016edba6c325bdd7350e04f65 IMO example binaries should be shipped separatly or in the "-dev" But ss a dev do you expect to "sudo apt install...

> > @seladb you can see the commit here [clementperon@bcf7577](https://github.com/clementperon/PcapPlusPlus/commit/bcf75779188692d016edba6c325bdd7350e04f65) > > IMO example binaries should be shipped separatly or in the "-dev" But ss a dev do you expect...

> Thanks @clementperon ! Which I guess it's running in your fork, no? Should we open a separate PR for it and close this PR? Yes it's in my fork....