Results 17 comments of Clement

Thanks to all contributors of MonitorControl! 😄 Finally I'm able to get rid of Dell's ddm.app. With MonitorControl I can change brightness of external displays by using macbook's function keys!👍

> 我这边 win 10 上可以正常启动并加载 test.rdb。wired... I have to say, it's `weird`, not `wired`🤣

I'm working on: - [ ] e2e/ctl_v3_member_test.go #14278 #14281 #14304 #14437 - [ ] e2e/ctl_v3_move_leader_test.go

> Created amended version of your PR #14313 as an example. It's a draft to showcase possible solution. I'll close it out and we can keep working on this PR....

Thanks to @ahrtr and @spzala for your help! This PR won't have gone so well without your collaboration.

This clue shows that a member of a cluster starts serving client before it's connected to all peers. ``` /home/runner/work/etcd/etcd/bin/etcd-22812: {"level":"warn","ts":"2022-07-27T08:46:33.653Z","caller":"etcdserver/server.go:1351","msg":"rejecting member add request; local member has not been connected...

> Hmm, maybe we should use `clus.WaitLeader()`? Wow, this is an amazing function, it looks like what I need. I'll give it try.

> One potential problem is adding members to 1 node cluster. In that situation we grow from 1 -> 2 member cluster. This means that quorum is now 2 member,...

As I went through the code base, I found that `clus.WaitLeader()` is called in many integration test cases, not in any e2e test case or the process of cluster creation....

> > > Hmm, maybe we should use clus.WaitLeader()? > > > > > > Wow, this is an amazing function, it looks like what I need. I'll give it...