clemahieu

I'd like to improve the algorithm we use here since we're in the area. The first issue I see is all the pending entries are added followed at the end...

Seems an is_final method on the vote class would sufficiently hide implementation details.

We force the API caller to do the conversion because of the general problem of using floating point math in finance.

I do wonder if we could interpret it as a fixed-fraction so it can be assured precision won't be lost.

We should look at a real number parser rather than manually slicing the string up. https://www.boost.org/doc/libs/1_75_0/libs/spirit/doc/html/spirit/qi/reference/numeric/real.html This also needs tests, specifically showing what it does to extreme values.

I like this strategy better than a separate RPC, we just need to make sure rounding errors can't happen.

If it doesn't have access to data.ldb it likely doesn't have access to the log directory though we could print an error to the console and exit cleanly.

Nodes advertise their inbound listen port with [::0]: in slot 0. When we used UDP we multiplexed all connections through the peering port so if we received a message from...

As a first step we should qualify what, if any, tests make the CI build fail.

The descending mode in the bulk_pull message will remain but the intent is for the bulk of the work to be done with this new mode. The legacy mode might...