Clemen comments

Results 30 comments of


                                            Clemen

A4A: Sites Dashboard - Update Dataviews version to latest

Discussion about the DataViews future on: pe7F0s-1OO-p2

A4A: Sites Dashboard - Update Dataviews version to latest

New reference: https://github.com/Automattic/jetpack-manage/issues/337

Site Management Panel: Add the guide tour to the primary button

> I made changes to let the GuidedTours components be reusable between Calypso and A4A. What do you think? @arthur791004, that is amazing! It's something I had in mind to...

Site Management Panel: Add the guide tour to the primary button

By the way, I forgot to say that this is a great refactoring code to make it reusable for everyone. Thanks, @arthur791004, for going ahead.

Site Management Panel: Add the guide tour to the primary button

@arthur791004 Wrapping/encapsulating the hook with the `useConditionalGuidedTours`, as I suggested above, didn't work?

Site Management Panel: Add the guide tour to the primary button

Question: ``` preferenceNames={ A4A_ONBOARDING_TOURS_PREFERENCE_NAME } eventNames={ A4A_ONBOARDING_TOURS_EVENT_NAMES } ``` Do those values affect Dotcom guided tours? they seem coupled to A4A

Site Management Panel: Add the guide tour to the primary button

For instance, `eventNames` has information about tracking events for A4A. If you use the Guided Tour at Dotcom, it will track events from Dotcom as if they were A4A events....

Site Management Panel: Add the guide tour to the primary button

All good 👍

Sites Dashboard V2: Support the row selection on the list view and increase the area of the action button

I dropped a comment in the issue...

A4A: Replace Marketpalce 'Add to cart' to 'Add to referral' button when in referral mode.

> Depends on https://github.com/Automattic/wp-calypso/pull/91090 ✅ Approved