wp-calypso icon indicating copy to clipboard operation
wp-calypso copied to clipboard

A4A: Sites Dashboard - Update Dataviews version to latest

Open gogdzl opened this issue 10 months ago • 20 comments

Related to https://github.com/Automattic/automattic-for-agencies-dev/issues/311

Proposed Changes

  • This PR updates wordpress/dataviews to the latest version (v1.0.0).
    • List of issues fixed:
      • Fixed status filter behavior, which changed in this version
      • Fixed dataviews styling when preview pane is open
      • Fixed scrolling

Testing Instructions

  • One of our components changed, so run yarn install to make sure everything is set-up properly.
  • Run yarn start-a8c-for-agencies
  • Go to http://agencies.localhost:3000/sites
  • Verify that the new version of our dashboard's dataview component is functioning properly in A4A. There have been some changes compared to our current version, which are outlined below, along with one known issue that we must disregard during testing.

Changes:

Filter selection

Previous Version: image

Latest:

image

image

When Preview Pane is open, filters now show multiple lines

Previews Version: image

Latest: image

Known Issue - Please ignore this one for now

When the Preview Pane is open and pagination is visible, the page's alignment looks off.

image

Pre-merge Checklist

  • [ ] Has the general commit checklist been followed? (PCYsg-hS-p2)
  • [ ] https://wpcalypso.wordpress.com/devdocs/docs/testing/index.md for your changes?
  • [ ] Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • [ ] Have you checked for TypeScript, React or other console errors?
  • [ ] Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • [ ] Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • [ ] For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

gogdzl avatar Apr 22 '24 12:04 gogdzl