Clay Allsopp

Results 68 comments of Clay Allsopp
trafficstars

Yeah - at a glance there are some problems with my original implementation. One is that `self` is referenced inside that block without being `weak`-ified, i.e. ``` __weak ShotBlocker *weakSelf...

I think this would be useful! if we keep backwards compatibility. I am wary of adding a bunch of options, but I think it's okay for now can we add...

awesome! can you add tests? the existing ones should point you in the right direction

That does look correct - in fact, shouldn't my original `dispatch_resume` call be removed too? Can you confirm that it still works as intended, without that call?

It would be! I'd love a PR for it, like `UPRouter#openURL`?

@aelam UITabBarController isn't well-supported within Routable right now. You could definitely use [anonymous callbacks](https://github.com/usepropeller/routable-ios#anonymous-callbacks) for now, but would welcome a PR that adds them as a first-class citizen

Hm so `toCallback` is sort of like a before filter? That would be cool, would prefer the order to be swapped and renamed ``` objc [[Routable sharedRouter] map:@"invalidate/:id" toController:[MyViewController Class]...

@NorthStar You mean something like `[router open:@"some/url" withExtras: @{@"something": else}]`? I can see that being handy