routable-ios icon indicating copy to clipboard operation
routable-ios copied to clipboard

Added shouldDismissPresentedViewController property to options

Open tspecht opened this issue 10 years ago • 3 comments
trafficstars

I recently had the need to stack multiple modal navigation controller in my app. Therefore I added a shouldDismissPresentedViewController property to the options to enable this functionality in my app. Maybe someone else finds that functionality useful :)

tspecht avatar Apr 01 '15 11:04 tspecht

I think this would be useful! if we keep backwards compatibility. I am wary of adding a bunch of options, but I think it's okay for now

can we add a test for this?

clayallsopp avatar Apr 01 '15 16:04 clayallsopp

@clayallsopp thanks for taking a look so fast, I just fixed the typos, added the method back in for backwards compatibility and fixed the indentation. Please also see my other comment.

tspecht avatar Apr 01 '15 17:04 tspecht

awesome! can you add tests? the existing ones should point you in the right direction

clayallsopp avatar Apr 01 '15 19:04 clayallsopp