Stefan Varga comments

Repositories
Issues
Comments

Results 4 comments of


                                            Stefan Varga

Add nullcheck for `window.event`

@evankirkiles What is the reason for closing this PR ? I tried to migrate from react 17 to react 18 and in some cases I have issues with this.

fix: Null check added when resolving event's priority

@josephsavona Thanks for quick answer. Yes, indeed it shouldn't be overwritten, but in real world I have experienced that client's app somehow is overriding this and I'm injecting a script...

fix: Null check added when resolving event's priority

@josephsavona I have added a test to cover this case. Cheers

fix: Null check added when resolving event's priority

@josephsavona Can we reopen this PR ?