Christian Clason

Results 1756 comments of Christian Clason

> Why are they separate? What is vim.net.download() doing that requires it to be separate from fetch() ? Nothing. `fetch == download` (PR you just closed), as opposed to full...

> fetch() aka request() aka download() Because these are **not** "aka". Requests are _much_ more general (`POST`!) than a simple `fetch`/`download`, and not having to wrangle request parameters for simply...

This is just luals's type inference being flaky. Ignore it for now.

Just as a note, this regression from "async v0" is a blocker for upgrading to v2 in nvim-treesitter.

Yeah, maybe it's cleaner not to put this into the `join` itself. Makes async v2 less of a drop-in replacement, but that's not a criticism (just means I need more...

See https://github.com/lewis6991/async.nvim/blob/main/lua/async/misc.lua for two variants of this.

Yeah, probably. The code is no longer luals compatible, and the semaphore join doesn't interleave tasks like the current code does.

> It should interleave tasks, it's intended to work exactly the same. When one task finishes a new one can begin. Hmm, I'm seeing a difference in nvim-treesitter: current `main`...

I just plonked the code into `nvim-treesitter` (replace `async.lua` with current master and `install.join` with your snippet above), then compared `:TSInstall! lua vimdoc` (or `./scripts/install-parsers.lua lua vimdoc`).