Christian Clason comments

Results 1778 comments of


                                            Christian Clason

refactor(treesitter)!: remove "all" option of Query:iter_matches

I need more time.

Improving julia queries

> format-queries fails for me on Wrong parser version; make sure you install the query parser with nvim-treesitter (just like every bundled parser) to guarantee it's compatible. (Upgrading Nvim 0.10.1...

build(lib): build using cmake

I don't think that's a net positive. Note that the issue is not the transitive reliance on the `cmake` crate but the need to maintain the cmake code -- especially...

build(lib): build using cmake

Well, yes; that's kinda my point: I'm missing a clear problem statement and a delineated scope for this. As Neovim shows, adding CMake files here is not _necessary_ for CMake...

build(lib): build using cmake

> If wasmtime requires downstreams consumers to use cmake, and treesitter wants to use wasmtime, then surely treesitter has to use cmake? Not quite; there's a difference between _depending_ on...

Warning mismatch? rule _ is just a `seq` or `choice` rule with a single element.

I think a similar false warning happens with https://github.com/hankthetank27/tree-sitter-liquid, which uses a function to construct some nodes, e.g.: https://github.com/hankthetank27/tree-sitter-liquid/blob/0419ac4868585320eee8615c90b864a1b04ef433/grammar.js#L357

Warning mismatch? rule _ is just a `seq` or `choice` rule with a single element.

Yeah, found the [hidden spot in tree-sitter-liquid](https://github.com/hankthetank27/tree-sitter-liquid/pull/2/files#diff-919ac210accac9ecc55a76d10a7590e3d85ca3f0e165b52d30f08faee486d0cb#503) as well. So the check is fine, but more verbose error messages would be welcome. In particular, the wording should make clear that...