Christian Clason

Results 1657 comments of Christian Clason
trafficstars

Definitely needs tests.

Looks good, thank you! (Test failure is CI flake.)

You need a c++ compiler for these parsers.

This will affect non-highlighting users of treesitter parsers, which `vim.treesitter.{start,stop}` until now did not (directly) affect. I think this might be an opportunity to talk about how we want this...

I don't think this should be configurable, because that means it _has_ to be configured. Instead, the goal is to have _semantic_ annotations for messages that allow them to be...

If Justin won't, I will require separate atomic commits. These sort of "update repo" PRs are simply unacceptable (even though -- most of -- the changes are welcome). > Oh,...

> Same, but I'm pretty sure this was not generated from a stable version but from a random commit (no idea which one) Then this is another reason to ask...

Superseded by #147 (except for the bindings, which should be a separate PR).

Yes, the Nim queries in nvim-treesitter are complete overkill, and a simplification would be very welcome. (Such hyper-detailed queries belong to a special-purpose plugin or personal config.) Regarding parser size...