Christian Clason

Results 1674 comments of Christian Clason
trafficstars

Please run the query formatter from nvim-treesitter (`./scripts/format-queries.lua` in that repo) on the new file.

Or are you possibly targeting a different parser? We use https://github.com/JoranHonig/tree-sitter-solidity/blob/master/grammar.js (which has no `consequence` field).

Please check your queries against the grammar. If you install the solidity parser with nvim-treesitter and open the query in a recent Neovim, the query linter should show you which...

I'm sorry, but are you using ChatGPT for this? Your queries bear little relation to the actual grammar.

No, that will not work at all. You need to look at the Solidity grammar specification I linked and work directly from that; you can't copy (even partially) queries from...

Adding new textobjects is something we do not do lightly. You would need to add them (with explanation!) to `CONTRIBUTING.md` (which is used in CI to enforce valid captures) and...

Sorry to be "that guy", but this broke font packages that conditionally require other packages based on package options (e.g., `notomath`). Is this known, and are there mitigation strategies?

Sure, give me a minute to extract the issue (it happens in a beamer theme).

```tex \documentclass{article} \usepackage[sfdefault]{notomath} \begin{document} Test \end{document} ``` The `sfdefault` option is what triggers the error: ``` This is pdfTeX, Version 3.141592653-2.6-1.40.26 (TeX Live 2024) (preloaded format=pdflatex) restricted \write18 enabled. entering...

Seems to be this line in `notomath.sty` that is the culprit: ```tex \ifnoto@sfdefault{\noto@MO{notosans}\else\noto@MO{noto}\fi ``` (which is defined by `\newif\ifnoto@sfdefault \noto@sfdefaultfalse`). I don't quite see why, but commenting it out removes...