Clark Winkelmann

Results 101 comments of Clark Winkelmann

I can't find where the documentation for the mimeDetector says how we are supposed to read that array https://github.com/SoftCreatR/php-mime-detector#usage @imorland you might want to take a look at this ?

When you disable the proxy, you loose both the "hot linking prevention" feature (if that was enabled) and you also lose the ability to restrict who can download the file...

It's been a while I have looked at how the extension works. I am actually not even sure that disabling the proxy is possible at all. We have two existing...

@qazwsdc that was my suggestion of how we could make it work. Currently proxy seems like the only implemented option :wink:

Makes sense. Should the option directly be to erase all exif data? That way every potential info is covered with a single setting.

Please open one issue per report. But now that it's already open let's discuss those things here first and see what we want to split. Does the file name thing...

There are 3 different templates that render an image: Image preview template: uses `img` tag with a `title` and `alt` attributes set to the label https://github.com/FriendsOfFlarum/upload/blob/98d02117bc152dbe548e06cd018a31d751273dca/resources/templates/image-preview.blade.php#L1 Image: uses a CSS...

Most likely the values will be blank in the preview, but they should be filled in the final render. You could check what the `base_name` value is for the file...

This is unlikely to be added outside of an important refactor. The current implementation relies on the files being accessible through HTTP, including for the access protection which uses an...

Sorry for not responding earlier. Thanks for your feedback, it makes total sense. We'll probably change this (and your suggestions in other issues) in future updates :+1: