epicgames-freegames-node icon indicating copy to clipboard operation
epicgames-freegames-node copied to clipboard

Use `node-epicgames-client` for Epic API backend stuff

Open davispuh opened this issue 3 years ago • 2 comments

Hi,

So I was working on https://github.com/Revadike/epicgames-freebies-claimer and https://github.com/Revadike/node-epicgames-client

But just found this project and it has a lot more functionality already so I think abandoning epicgames-freebies-claimer and using this instead.

But here is a lot of functionality implemented that's already part of https://github.com/Revadike/node-epicgames-client so would you accept a PR which refactors this out and uses node-epicgames-client as dependency instead?

davispuh avatar Aug 31 '20 14:08 davispuh

I was aware of node-epicgames-client a while back. I had a few concerns that prevented me from using it:

  • Lack of types
  • Uses deprecated request client
  • Lack of cookie jar swapping

I'd love to use it since my Epic Games reverse engineering is pretty rough, however node-epicgames-client doesn't fit with this project, yet.

claabs avatar Aug 31 '20 14:08 claabs

That's great and those are very minor things, easily fixable. I think there could be TypeScript wrapper over it's API.

BTW I just added bunch of GraphQL documents there https://github.com/Revadike/node-epicgames-client/pull/8/files My main point is having less duplicated work.

davispuh avatar Aug 31 '20 14:08 davispuh