christn

Results 11 comments of christn

I'd love to take a shot at implementing this, if it is considered a desirable feature.

> It would be cool but it's really really hard to do. You would need to keep track of the instruction counter (not the program counter), identify the contract, look...

> > Therefore pending transactions are disregarded resulting in incorrect behaviour > > can you elaborate on this? > > we only estimate the transaction with the current state I...

For example in the case of the transactionCount we are already incorporating the pending transactions: https://github.com/foundry-rs/foundry/blob/26893ff421093f0904f04db02407b180ee8d5e6e/anvil/src/eth/api.rs#L1875

Ready for review. @onbjerg I commited the changed testcase into a separate commit (where it is failing) to illustrate the issue this pr is solving. Lmk if I should squash...

If this PR is merged, it'd probably be best to do so before redeploying to a new testnet. See: https://github.com/OpenZeppelin/ethernaut/issues/340

Fwiw: I'd be more than happy to implement this, if it's deemed a desirable feature. As far as I can see it should be done in just a few lines...

Went ahead and implemented this in https://github.com/dethcrypto/TypeChain/pull/735

Just encountered the issue as well. @ewenmcneill Thanks for the fix. I took the liberty and opened a PR with the solution from your git diff, hope that's okay. https://github.com/rust-in-action/code/pull/107/files

I was going down a bit of rabbit hole, since I (naively) thought that this should be straight forward to implement. I ran into the wall of the problem of...