Chuan-kai Lin

> Generally looks reasonable, but I do have several stylistic and algorithmic comments. I don't like the code duplication introduced in the queries and the way that they shadow the...

> Generally looks reasonable, but I do have several stylistic and algorithmic comments. > I don't like the code duplication introduced in the queries and the way that they shadow...

I am able to reproduce the `CWE-927/ImplicitPendingIntentsTest.ql` test failure locally and it is due to https://github.com/github/codeql/pull/17190/commits/1b0c1d6cd48f9c51c11d9c18f8c9843739e235a1. I will track down the problem and come up with a fix.

> I am able to reproduce the `CWE-927/ImplicitPendingIntentsTest.ql` test failure locally and it is due to [1b0c1d6](https://github.com/github/codeql/commit/1b0c1d6cd48f9c51c11d9c18f8c9843739e235a1). I will track down the problem and come up with a fix. The...

> > The problem was due to `FilteredStateConfig` missing pass-through aliases for some default predicates in `StateConfigSig`. I added the missing predicate pass-throughs and also verified that `FilteredConfig` has the...

> That seems too brittle - and also not very nice to have all those pass-throughs. Perhaps filtering should merely be a flag on the existing configuration instead of a...

> I think we should limit ourselves to filtering that affects data flow, as the other query result filtering cannot be expected to improve performance. I have updated the PR...

Hi @mbg, Thank you for your detailed comments. Before we go into the details, can you confirm that I understand your main concerns correctly? 1. You are concerned that this...

Later successful run: https://github.com/github/vscode-codeql/actions/runs/20216581718