Kartik Chopra

Results 10 comments of Kartik Chopra

Yeah same, seems like https://github.com/nucypher/pyUmbral is the most up-to-date usage.

It's hard to find comparisons, as SnarkyJS more rapidly changes its API than more mature platforms with stable documentation and releases. You allude to a good point, how do we...

Still need to update the contract, but would appreciate if you could review what I've got so far @aloknerurkar, especially the RPC portion.

An example error occurs when a provider node is unstaked, the resuling logs simply indicate an inability to connect to the p2p network, with no additional information

This already exists, but we need to make sure the mev-commit node actually de-registers them when the stake is withdrawn.

Similar issue on withdrawl /// @dev Event emitted when a bidder withdraws their deposit event BidderWithdrawal( address indexed bidder, uint256 indexed window, uint256 indexed amount );

We should also be tracking the amount of funds being added here, which we're not. We only track net funds in the window.

We can make the new changes to mev-commit in follow on PRs, I'd rather keep contract code changes in a single PR. @aloknerurkar

Yes, will be making a new one @ErinOCon