CJ Yetman

get rid of `{janitor}`

1

It's a bit unfortunate that we have this dependency on `{janitor}` which... 1. we only use for `janitor::clean_names(data)` and `janitor::make_clean_names()` 2. we then have to maintain this complex system of...

This issue keeps coming up again and again in different contexts.... 1. How do users know what packages are needed? 2. How do users install the packages they need? 3....

extend styler action to R files not in R directory

2

Currently, the PR commands GitHub Action workflow only runs `styler` on R files that are in the `R` directory. https://github.com/2DegreesInvesting/PACTA_analysis/blob/8af0ac58bf48807f3d77d651a5271e1900b02f7f/.github/workflows/pr-commands.yaml#L46 Could this be modified to work with `styler::style_dir()` instead and...

bonds and equity with valid_input==FALSE

5

I found a few cases where bond and/or equity holdings have `valid_input==FALSE`. My expectation, after the change in #17, is that this should not be possible? (based on data created...

remove `map_security_sectors()` once its purpose is shifted to 2DegreesInvesting/data_preparation

2

Once 2DegreesInvesting/data_preparation/issues/14 has been resolved, we should remove `map_security_sectors()`, whose purpose should be fully superseded by whatever is implemented over there.

I have built multiple packages that rely on r2d3 and they would benefit from minor changes and maintenance here, not to mention it would be ideal to depend on a...