CJ Yetman

cctld as origin code does not work as expected

4

First, in the help file for codelist, it lists "ccTLD" as an origin and destination code, however it is named "cctld" in the actual `codelist` object. Second, I haven't fully...

Regex: simplification

12

Is there any advantage to having complicated regexes versus a list of alterations of known variations, other than brevity? For example, U.S. Virgin Islands... "^(?=.*\\bu\\.?\\s?s).*virgin|^(?=.*states).*virgin" versus "United States Virgin Islands|US...

deal with tibbles and 1 column data frames gracefully

7

We could add [here](https://github.com/vincentarelbundock/countrycode/blob/master/R/countrycode.R#L106) something like... ```r if (mode(sourcevar) == "list" && length(sourcevar) == 1) { sourcevar

When `simplifyVector = TRUE` and a vector contains only "NA" strings, they are converted to `NA`, otherwise they are converted to strings `"NA"`. This can be a problem if the...

`left_join()` error message names wrong variable in `y`

1

When joining two tables by differently named columns, if they are incompatible types the error message uses the name of the by column in table x as the name of...

add a markdown output function

3

an exported function like `cover::markdown_output()` to print a coverage report in markdown, which could then easily be used to add either a [Job Summary](https://github.blog/2022-05-09-supercharging-github-actions-with-job-summaries/) for a GH Action, or potentially...

`pkg-config` also required for install on macOS

2

While trying to install {pdftools} on macOS (ARM64), I ran into problems, even after manually installing poppler with `brew install poppler`. I was getting the following error message ``` ---------------------------...

multi-byte `grouping_mark` doesn't work when source file is different encoding

4

Using a multi-byte character as a `grouping_mark` doesn't work when the source file encoding is "windows-1252", while other uncommon non-multi-byte strings work as expected. I'm on macOS in UTF-8 locale....

`TÜRKİYE` a valid spelling?

10

The [list-one.xls](https://www.six-group.com/dam/download/financial-information/data-center/iso-currrency/lists/list-one.xls) that we use from https://www.six-group.com/en/products-services/financial-information/data-standards.html to get the ISO4217 codes in [get_iso4217.R](https://github.com/vincentarelbundock/countrycode/blob/main/dictionary/get_iso4217.R) (or better, will use once the URL is updated in an PR #348) uses `TÜRKİYE` (note...

update world_bank scraper

6

Caution: causes many changes/moves in the data CSV