Carter Swedal

Results 14 comments of Carter Swedal

> > Add featuremap to MediaPlayback xml definition > > @cjswedes I don't see that in the PR? @bzbarsky-apple I updated to add a globalAttribute tag for featuremap, and updated...

> I agree with your comments. What we previously used was closer to what you described, but it seems the hubs or a different component in the SmartThings arrangement was...

At the end of the device_init handler you can setup a cosock task to do the devices polling operation at the correct interval like this: ```lua local cancel_tx, rx =...

The main two issues I see which need to be addressed are: 1. the periodic multicast discovery running every 30 seconds 2. the way devices are initialized when first added...

Looks like luacheck isn't passing. We would like to keep this passing, so please make the changes to address it. You can view the errors in CI, but here they...

I added the do not merge label since this will break unit tests (due to the second bug mentioned) until 0.46.x release occurs. There is not an easy hack around...

> I would push to switch over to using the latest dev artifact, but I worry that would lead to us accidentally pushing changes to prod that will break on...

@tpmanley @greens @ctowns This is ready for a review. It is essentially adding the support for thermostats that have ThermostatOperatingState capability, which is based off the optional attribute ThermostatRunningState. I...

Due to the weird energy reports I have gotten from the device I see a few options to move this PR forward: 1. Remove energyMeter cap from the insight devices...

Looks like there is a test for `zigbee-motion` that was actually testing the healthcheck functionality. Since we are removing the functionality, we can just remove the test. https://github.com/SmartThingsCommunity/SmartThingsEdgeDrivers/blob/0ccdd939fc904f90798c370ed675b1803d880c84/drivers/SmartThings/zigbee-motion-sensor/src/test/test_all_capabilities_zigbee_motion.lua#L175