Collin Overbay

icon indicating a website link http://www.collincodes.com

icon location San Francisco, CA icon location Software Engineer at Indeed.com Comp Sci and Physics Grad Interested in Machine Learning, Quantum Computing, Web Sockets, Image Recognition, Neural Network

Results 3 issues of Collin Overbay

Comment seems incorrect

https://github.com/amitabhyadav/Shor-Algorithm-on-IBM-Quantum-Experience/blob/ab2f496249a5ea56d572e38e90742871bc884599/Shor_version2_5bit_simulation.py#L100

What about the other possible factor: gcd(a**(r/2) - 1, N)

https://github.com/amitabhyadav/Shor-Algorithm-on-IBM-Quantum-Experience/blob/master/Shor_version1_5bit_hardware.py#L118 https://github.com/amitabhyadav/Shor-Algorithm-on-IBM-Quantum-Experience/blob/master/Shor_version1_5bit_hardware.py#L159 According to the [algorithm](https://en.wikipedia.org/wiki/Shor%27s_algorithm), at least one of the following is a nontrivial factor of N: - gcd(a^{r/2}+1,N) - gcd(a^{r/2}-1,N) It seems that the code is neglecting the...

Missing LICENSE.md

I noticed in README it mentions MIT license, but there is not LICENSE.md in root of directory. I found this from your a google search -> article - https://medium.com/@saverio3107/fastapi-langchain-rag-repository-e97ef42b9d19 Would...