Craig Newbury

Results 7 comments of Craig Newbury

Today I had to work on a fix (well a workaround) for a headless checkout we are working on due to this _bizarre_ architectural decision. Looking at this definition: ```...

Totally forgot I PR'd this. I'll try summarise test/use cases and see if i can figure out how to write a test for it.

So I have taken some time to figure out how to write "fixer tests" and it looks like `\PHP_CodeSniffer\Tests\Standards\AbstractSniffUnitTest` already has the built in logic to handle this. All I...

I also think your 2 examples are valid. I will next: - Update the tests with the expected outcome, - See if I can implement this in an update to...

@arushibansal013 I have created a PR (#204) that adds the ability to use `phpcbf` to remove automatically. Is it worth me adding `@author` in the same PR?

@Morerice Thanks for reaching out for community feedback. I haven't had time to look into this yet (Will review when I get a moment 🙂 ) but I have shared...

@luka4 Thank you for this! I was using a custom patch that just commented out lines 79-85 but your patch kept the functionality. For context we had about 260K files...