Chris Colvard
Chris Colvard
There were missing keys from the generated JSON so the original reason for the conversion seems valid. I'm not sure what keys are dropped and if they're important though.
I did some testing and found some issues that may or may not be related: When switching sections auto.m3u8 takes ~1.5 s, /stream takes 7s->3.3min Ran into problem with session...
Looking at clover they seem to recommend have a top-level fetch and then pass the values as props to "primitive" components (https://github.com/samvera-labs/clover-iiif/blob/main/pages/docs/composing.mdx#L166-L191). For non-primitives like Viewer they pass the manifest...
Another refactor idea: Use React refs in place of state hooks to avoid the number of rerenders. For example structure navigation clicks cause a rerender of that component.
Here is the context where I was seeing this infinite loop: https://gist.github.com/cjcolvar/6045c3bab2bea66d8b02d65e553522a3
@dmolesUC This seems to be a particularly knotty thing in the code. From what I can tell Hyrax has a [CharacterizationJob](https://github.com/samvera/hyrax/blob/main/app/jobs/characterize_job.rb) which uses the Hydra-Works [CharacterizationService](https://github.com/samvera/hydra-works/blob/main/lib/hydra/works/services/characterization_service.rb) which calls Hydra-Characterization's [Hydra::FileCharacterization](https://github.com/samvera/hydra-file_characterization/blob/main/lib/hydra/file_characterization.rb)...
I think I found the source of the problem and have a PR to resolve it: #6925
Part of https://github.com/avalonmediasystem/avalon/issues/6397
Science History Institute example: https://digital.sciencehistory.org/works/x8peubh
Part of https://github.com/avalonmediasystem/avalon/issues/6397