hyrax icon indicating copy to clipboard operation
hyrax copied to clipboard

Update show.json.jbuilder

Open cjcolvar opened this issue 2 years ago • 2 comments

Test skipping converting Hyrax::Resource objects back to ActiveFedora::Base objects because both support class.fields.

cjcolvar avatar Jul 25 '23 19:07 cjcolvar

Hi @cjcolvar, thanks for the test

The commented line:

@curation_concern = Wings::ActiveFedoraConverter.convert(resource: @curation_concern)

Caused a significant delay in generating the json response, so commenting it out considerably improved response times when consuming json from a SPA, which would be my case.

rodyoukai avatar Jul 25 '23 20:07 rodyoukai

There were missing keys from the generated JSON so the original reason for the conversion seems valid. I'm not sure what keys are dropped and if they're important though.

cjcolvar avatar Jul 26 '23 17:07 cjcolvar