Jiri Cincura ↹

Results 100 comments of Jiri Cincura ↹

What I said in https://github.com/FirebirdSQL/NETProvider/issues/722#issuecomment-826216267 still applies.

I was looking at it from end user POV. For these Firebird works in 3 possible configurations. But if it doesn't seem to make sense, it's fine. BTW I also...

Hmm, the failing build doesn't look good. Now whether it found real issues or it's a bad change. I still think the new code is correct, isn't it?

I got the inspiration as I was writing [my code](https://github.com/cincuranet/FirebirdSql.Data.FirebirdClient/blob/master/Provider/src/FirebirdSql.EntityFrameworkCore.Firebird/Migrations/Internal/FbHistoryRepository.cs#L47) and also [SQLite provider does the same](https://github.com/aspnet/EntityFrameworkCore/blob/master/src/EFCore.Sqlite.Core/Migrations/Internal/SqliteHistoryRepository.cs#L56). The original condition makes sense in case of SQLServer, because [the query is...

Doesn't matter. The `Convert` will handle it.

> Maybe make sense to add _HANDLE suffixes too. That would also be to deal with reserved words, as for example, CLOSE is a reserved word. That would make sense...

Hmm. _SmartyPants_ is using `OpeningCharacters` while my `'` can be anywhere (see my example). Your idea of directly changing the parser is good. I can disable then the balancing checking.

Finally somewhat hacked it together. There's not much changes at the end. Here's the diff (some whitespaces are fucked up, I know): https://github.com/cincuranet/markdig/commit/192b875055f349b58057fa8f1582581d97cedfb5?w=1 . Not sure whether it's too far...

High level tracking for Firebird is [here](https://github.com/FirebirdSQL/NETProvider/issues/1083).

> is any special configuration to be done in IIS with NET 6+FB None that I'm aware of.