Cijo Thomas
Cijo Thomas
Issue exists outside of OpenTelemetry also, as shown in below code. ``` static void Main(string[] args) { var factory = LoggerFactory.Create((builder) => builder.AddConsole()); var logger = factory.CreateLogger("testCategory"); logger.LogError("Sample error"); factory.Dispose();...
https://github.com/open-telemetry/opentelemetry-dotnet/pull/2718 changes the layout, so this will be affected.
https://github.com/open-telemetry/opentelemetry-dotnet/pull/2705/files - need to bring this back as well. (it was reverted)
https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/src/OpenTelemetry/Metrics/MetricType.cs also see this class.
@CodeBlanch I am now unsure if this is something OTel repo should provide? Its like a general serilog enricher, for enriching with `Activity.Current`. This does not have anything to do...
Thanks for this PR @al-mac ! @alanwest Please do add this to SIG discussion. I was chatting offline with @vishweshbankwar for some potential improvements in this area as well. (Its...
https://github.com/open-telemetry/opentelemetry-dotnet/tree/main/src/OpenTelemetry.Extensions.Hosting I think this is covered when using OTel.Extensions.Hosting package. (JaegerExporter currently support this, but not really documented in its readme file). Example: https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/examples/AspNetCore/Startup.cs#L73 Please see if Extensions.Hosting package addresses...
Linked issue : https://github.com/open-telemetry/opentelemetry-dotnet/issues/3373
https://docs.microsoft.com/en-us/aspnet/core/fundamentals/http-logging/?view=aspnetcore-6.0 Might be able to borrow some ideas from this, regd. what tags gets populated / not.
We should remove pattern matching and rely on exact names!