Adding MinMax to Histograms

[mic-max]

Fixes #2560

Changes

Histograms will now record the minimum and maximum measurement values.

For significant contributions please make sure you have completed the following items:

• [x] Appropriate CHANGELOG.md updated for non-trivial changes
• [ ] Design discussion issue #
• [x] Changes in public API reviewed

[codecov[bot]]

Codecov Report

Merging #2735 (a282844) into main (af7ab89) will decrease coverage by 0.42%. The diff coverage is 76.59%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2735      +/-   ##
==========================================
- Coverage   87.35%   86.92%   -0.43%     
==========================================
  Files         277      278       +1     
  Lines       10068    10151      +83     
==========================================
+ Hits         8795     8824      +29     
- Misses       1273     1327      +54     

Impacted Files	Coverage Δ
...ry/Metrics/ExplicitBucketHistogramConfiguration.cs	83.33% <ø> (+22.22%)	:arrow_up:
src/OpenTelemetry/Metrics/MetricPoint.cs	75.00% <71.79%> (-8.00%)	:arrow_down:
...tryProtocol/Implementation/MetricItemExtensions.cs	93.95% <100.00%> (+0.12%)	:arrow_up:
src/OpenTelemetry/Metrics/HistogramBuckets.cs	100.00% <100.00%> (ø)
...rc/OpenTelemetry/Metrics/HistogramConfiguration.cs	100.00% <100.00%> (ø)
src/OpenTelemetry/Metrics/Metric.cs	95.50% <100.00%> (+1.12%)	:arrow_up:
src/OpenTelemetry/Metrics/MetricReaderExt.cs	86.36% <100.00%> (+1.81%)	:arrow_up:
src/OpenTelemetry/Metrics/MetricStreamIdentity.cs	90.62% <100.00%> (+0.62%)	:arrow_up:
...entation/ExportClient/OtlpGrpcTraceExportClient.cs	35.71% <0.00%> (-42.86%)	:arrow_down:
...xporter.OpenTelemetryProtocol/OtlpTraceExporter.cs	36.36% <0.00%> (-40.91%)	:arrow_down:
... and 14 more

[cijothomas]

https://github.com/open-telemetry/opentelemetry-dotnet/pull/2718 changes the layout, so this will be affected.

[cijothomas]

https://github.com/open-telemetry/opentelemetry-dotnet/pull/2705/files - need to bring this back as well. (it was reverted)

[cijothomas]

https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/src/OpenTelemetry/Metrics/MetricType.cs also see this class.

[github-actions[bot]]

This PR was marked stale due to lack of activity. It will be closed in 7 days.

[github-actions[bot]]

Closed as inactive. Feel free to reopen if this PR is still being worked on.

[mic-max]

Could this be reopened please :)

[github-actions[bot]]

This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day.

[jdaigle]

Comment to keep this open. I'm excited and eager to see this changed merged and released.

[github-actions[bot]]

This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day.

[github-actions[bot]]

This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day.

[github-actions[bot]]

This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day.

[github-actions[bot]]

Closed as inactive. Feel free to reopen if this PR is still being worked on.

[arianmotamedi]

Can this be reopened? Is it being worked on?

[utpilla]

@mic-max Please resolve the merge conflicts for getting this PR ready for review.

[github-actions[bot]]

This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day.

[ejsmith]

Would love to have this. For me, I'm recording queue processing times and having the average is alright, but what I really want to know is what the max time is.

[ejsmith]

I guess there wouldn't be any way to get something like the 99th percentile from a histogram even with this change. I was reading docs on OpenTelemetry specs and it seems like doing percentiles isn't really going to be supported.

[cijothomas]

I guess there wouldn't be any way to get something like the 99th percentile from a histogram even with this change. I was reading docs on OpenTelemetry specs and it seems like doing percentiles isn't really going to be supported.

Histogram exports buckets, allowing backends to calculate percentiles.

[github-actions[bot]]

This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day.

[ejsmith]

Do we need help getting this completed and merged? It seems like an important feature for otel metrics.

[mic-max]

Let me know when you want to merge this and I will resolve the conflicts, not going to waste my time fixing preemptively just for new conflicts to come up

[cijothomas]

The PR looks good except for 2 things:

1. MinMwx should be part of Identity. Must be fixed in this PR.
2. Other exporters will break with this change. The fix is in other exporters, but blocking PR to prevent accidental merge until exporters are hotfixed. See https://github.com/open-telemetry/opentelemetry-dotnet/pull/2735/files#r989476122

if we keep the metric type same, then it wont break existing exporters. and can use Nan/Infinity to indicate lack of min/max

[cijothomas]

Merging. @alanwest please take a final look and share any issues you see!