Cijo Thomas
Cijo Thomas
Thanks! Assigned. Lack of test is giving me less confidence to do big refactoring to get perf boost. For now I'll focus on Counters, which do have some coverage.
Closing as we have this mostly covered.
@TommyCpp Opened this as discussed in the community call.
Partially addressed via https://github.com/open-telemetry/opentelemetry-rust/pull/2984
Fully fixing requires remove the validation done at instrument creation time (before applying views), and doing everything after applying view(s)
@utpilla @fraillt FYI. Something we can discuss.
TODO: Also check this for other signals like Logs. Add tests to confirm the current behavior and if they are behaving as expected or not.
Removing from stable milestone. This is nice-to-have, but not a blocker for SDK stable release.
Could be change in SDK only? Okay to do this in next to next release 0.28, *not* in 0.27 to keep 0.27 release scope under control.
@copilot Do cargo fmt, and also apply any clippy suggestions too.