Cijo Thomas

Results 1310 comments of Cijo Thomas

It was a conscious decision to pre-allocate to the exact cardinality-limit, to generally follow the idea of not having to ask for more memory in Metrics SDK after initialization. (though...

It is also bad to not pre-allocate, as it can trigger internal resizing/copy in measurement recording path. Are you seeing scenarios where user over-provision cardinality limit? There aren't many guidelines...

Removing from MetricSDK Stable milestone - this is not a blocker. The changes should be fully internal with no public API changes required.

https://github.com/open-telemetry/opentelemetry-dotnet/issues/5462#issuecomment-2610942277

> I suspect there may be many usages of ILogger's EventId out there in the wild that does not conform to the [event conventions](https://github.com/open-telemetry/semantic-conventions/blob/main/docs/general/events.md), specifically: > > The event name...

> These are two distinct types of events in ILogger, but they'd be considered the same in OpenTelemetry since the proposal is that we only include EventId.Name in LogRecord.EventName. Should...

> Maybe what we need is the ability for the user to configure the LoggerProvider how to derive event name. Yes that sounds reasonable. Maybe do ILogger.EventId.Name as default, and...

> record EventId.Id as event_id, and place this behind an experimental flag, making it opt-in Did you mean "event_id" attribute? If yes, the its easier to stick with the existing...

https://github.com/open-telemetry/opentelemetry-dotnet/pull/5407 Looks like this was added, but requires `openmetrics` format.. Are you scraping while requesting for open metrics format?

@hawkw @davidbarsky Could you review this PR and take it forward? We are really looking forward to using this from OpenTelemetry and OpenTelemetry-Arrow projects!