Cijo Thomas

Results 1134 comments of Cijo Thomas

@lalitb Thanks for digging further! It looks like we need to redesign SimpleProcessors too, as it cannot be used with `#[tokio:main]`.

We have some minimal automation via scripts in OTel Rust for publishing to crates.io https://github.com/open-telemetry/opentelemetry-rust/blob/main/scripts/publish.sh There is no notion of "reserving" prefix/namespace, so it may be good to settle on...

What are "dependencies"? Are you referring to the Database Spans? Please share a [minimal repro](stackoverflow.com/help/minimal-reproducible-example) explaining the issue, so we can help further.

@ep-workai Please share a [minimal repro](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/issues/stackoverflow.com/help/minimal-reproducible-example) explaining the issue, so we can help further. You can take the helloworld OpenTelemetry example, and incrementally add things to until the issue reproduces....

Spec wording is bit ambiguous: > "If the SDK implements attribute limits it MUST provide a way to change these limits" I assumed it meant that all SDK MUST implement...

https://github.com/open-telemetry/opentelemetry-rust/blob/main/opentelemetry-otlp/tests/integration_test/src/test_utils.rs#L51-L54 This is where we enable `fmt` layer to collect all SDK internal logs. This is not required if we already print logs to stdout in Test configuration.

There is something about Baggage should be immutable, so adding a new entry should result in a new Baggage?

https://github.com/open-telemetry/opentelemetry-rust/blob/main/opentelemetry/src/baggage.rs#L322-L325 With Baggage should be just taking `Baggage` as input? Right now it takes `KeyValueMetadata` which is also hence forced to be a public API.

https://github.com/open-telemetry/opentelemetry-rust/blob/main/opentelemetry/src/baggage.rs#L159 Look like we are restricting Baggage keys to be just ASCII, but spec allows any. This maybe okay, as non-ascii may have issues with propagation. However I think we...

Baggage must be keyed in Context using a non-public class instead of Baggage. https://github.com/open-telemetry/opentelemetry-rust/blob/main/opentelemetry/src/baggage.rs#L377 ```rust #[test] fn baggage_context() { let ctx = Context::new().with_baggage(vec![KeyValue::new("my-name", "my-value")]); let baggage_from_ctx = ctx.baggage(); assert_eq!( baggage_from_ctx.get("my-name"),...