CL Fisher
CL Fisher
> Overall this looks good - congratulations, I don't think I've ever reviewed a PR this big before! 😂 Had a few nits. > > @cielf how do we want...
Cool! I'll slot in doing some testing over the next couple of days.
I did some light manual testing - and didn't find anything broken. @dorner?
I don't know of any reason not to merge once the conflict is resolved.
@dorner Hrm. I have to apologize -- I didn't come back into this issue and address the fact that we had settled on just "units" for the default units.
@dorner I think we're going to need something on ItemRequest as well -- that' s the level that the packs or whatever will actually be requested.
> @cielf not sure how using "units" as the default changes anything... that should be purely on the display side. We said that we'd stick with `null` to indicate "no...
@dorner Cool. I also think we don't need "reporting unit" on item -- that would always be "unit" , the way we are thinking of things now, right?
Hmm. That doesn't *sound* right? Let me take another look. We may have had a terminology mixup.
@dorner This is nitpicky and maybe a bit out of scope -- I ran the setup, and inspected the results -- I see a request with two ItemRequests for pads...