CL Fisher

Results 1061 comments of CL Fisher

Closing this -- it appears the items are in machine-alphabetical order. Which is consistent with the rest of the system -- I believe we should be doing a case insensitive...

It looks like it's looking for a certain number of "50"s , but the bank name that has been created for this test, with this particular seed has a 50...

If that's the case, I would expect the following test to also have a seed for which it does not work. Also any other tests where we are counting the...

Yup -- confirmed that that has also happened.

@elasticspoon : Therefore I think specifying a name for the organization in distribution_by_county_shared_example.rb might do the trick.

Ok -- this is beyond what was asked for, but could we add in the storage location? "You are about to create a distribution for [partner name] from [storage location]...

And... I just noticed that we're using the terminology "to request" -- the issue was cloned from a similar one for requests. Could we change that wording "Please confirm the...

(thinks) (not a request for change) So... if they walk away from this, we'll have a pending distribution in the database, temporarily. If that's the case, we need to check...

Pointing out, in case it makes a difference in the least of evils discussion -- that we are going to be doing a very similar thing for the requests as...

On the surface of it, that sounds great, *and* I certainly want @dorner's take on it. Other possible concerns would be if we're going to have people having issue with...