CL Fisher
CL Fisher
Oh -- also on the donation -- I wasn't clear -- the error around the negative inventory is an uncaught error, so they'd get a 500. On the distribution, it...
It does look like this is safe when the read_events flag is disabled though. I have not been able to recreate the problem with the inventory going kerfluey. I was...
I spent awhile testing this with the flag on, and it definitely does what I expect it to.
Found another problem that is related to the reduction of inventory. If you have that kind of error, at least in donation, the name of the item in question goes...
@dorner One last thing -- that error is going to be pretty confusing if it ever comes up. What action should the user take if it does -- contact us?...
@dorner Whoops --the crash also happens on finalizing audit. Please address.
There really isn't anything else that we really want them to contact us for. It's an exceptional case (which I hope we never actually have once we get events fully...
@awwaiid -- can you do the tech review up to this point, please? (Handling the outstanding text change is well within my abilities to confidently o.k.)
@dorner There are a couple of suggestions from Brock -- could you take a quick look at them and confirm or deny? Thanks.
@awwaiid Not a formal review, but I'll be adding my impressions here. 1/ Let's remove the Items on hand / make a transfer / make an adjustment. Transfers and adjustments...