rubyforgood
Dashboard!
This is an epic feature branch that moves more historic-reporting-oriented blocks off of the dashboard and adds some action-oriented blocks in. We'll review and merge it as a slate!
@awwaiid Not a formal review, but I'll be adding my impressions here. 1/ Let's remove the Items on hand / make a transfer / make an adjustment. Transfers and adjustments are hopefully really rare, and the items on hand total is not part of the in-your-face gotta-take-care-of-this-today nature of the new dashboard
2/ I think we should consider extracting the Audit from the list and giving it's own space. A potential problem with that, though, is that the left hand menu is going to be longer than most screens (is it now?)
3/ We do have to reorder the reports, though (the current order is kind of random). Assuming that we're keeping the audit in that list, I've got a couple of possible orders to put forth:
Candidate 1 -- in roughly the same order as we have the items at the top of the lhm.
Inventory Audit Product Drives Summary Donations Summary Itemized Donations Manufacturers Donations Purchases Summary Distributions Summary Itemized Distributions Distributions by County Annual Survey Activity Graph
Candidate 2: Audit, then Alphabetical, but with some renaming
Inventory Audit Activity Graph Annual Survey Distributions Summary Distributions - Itemized Distributions by County Donations Summary Donations - Itemized Donations - Manufacturers Product Drives Summary Purchases Summary
What do you think?
4/ Something I noticed, and it's legacy, so if you want it to be a separate issue, that's cool -- the period text (i.e. during the period 01 Jan to 31 Dec) isn't handling years other than the current one in a good way -- that is, it is not showing the year.
I like the second set. You're right that the menu is getting long; this ordering does keep Audit at the top so maybe that'll be fine?
5/ Just noting that there is an inventory level on Itemized donations and itemized distributions -- with the moving parts we'll need to remember to check that with event source.
6/ Note - possibly for another issue. Legacy. "Recent purchases" is not quite an accurate title for a list of the latest purchases for that period. Maybe "Latest purchases during the period" But that is wordy.
Ditto Distributions and Donations.
7/ The date filter box on Distributions by County is insufficiently wide. Also a legacy issue.
@awwaiid Not a formal review, but I'll be adding my impressions here. 1/ Let's remove the Items on hand / make a transfer / make an adjustment. Transfers and adjustments are hopefully really rare, and the items on hand total is not part of the in-your-face gotta-take-care-of-this-today nature of the new dashboard
This same block has two more things -- the logo and the onboarding. I'm updating it so that the onboarding takes over, but I don't know what to do about the logo other than removing it (if they are done onboarding the whole block goes away). Any suggestions?
@cielf @dorner Yes please take another look; I addressed much of the feedback. Biggest thing that I'd rather do separate is further refactoring of the specs (removing redundancy, moving system->request). Though as always I'll follow consensus :)
I'm continuing to see a few flaky tests that I'm continuing to investigate.
Actually I found two issues -- some menu entry current-selection problems and one report that didn't get unified. Fixing...
I'm OK with moving the spec fixes to a fast-follow... but it really should be a fast follow. We have way too many system specs as it is...
@awwaiid A test is failing that I don't think is one of the normal flakey tests, and it failed on rerun.
Kicking the tires now.
1/ Bank-wide low inventory should not show inactive storage locations. These will have 0 inventory, and we wouldn't want them to show up "in your face" all the time.
2/ I tested against some live data, and the "Requestor" column on the Outstanding Requests column was completely empty. Is this showing the name? I suggest having it should show the name, but if no name the email?
3/ Outstanding requests looks like it's showing all the requests, not just the pending ones. It should only show the pending and started ones.
Looking further into this, I can't bring up the first request in the list through the requests index. So there's something odd. Looking further into it still.
3a/ Oh. My. It's showing the pending requests for all the organizations, instead. That is, obviously, not what we want g.
Basic testing of the reports area looks good -- A lot of things are very slow, but that is a separate issue.
@awwaiid Actually, and I apologize for the late thought... I'm wondering if the low inventory report should just be against the bank-wide inventory instead of storage-location level. We have a stakeholder meeting on Wednesday -- let's take that question to them. (Edit -- in the planning meeting we decided to go ahead with this and just push it through as bank-level. Reasoning -- We're pretty sure some banks have big SLs and little SLs but we don't differentiate on the recommended and minimum quantities, so there will potentially be a lot of noise if we keep it at the SL level)
I'm OK with moving the spec fixes to a fast-follow... but it really should be a fast follow. We have way too many system specs as it is...
I went ahead and moved them all.
@cielf @dorner this is ready for a re-review. I apologize in advance if I missed something you already gave feedback on, I had a hard time keeping track of what I already fixed.
Not a showstopper, but I am wondering, with 4 'cards', why we have 3 in the left column and 1 in the right?
For discussion on Sunday -- Should, we, perhaps, make the reports in the dashboard full-width instead of having the two columns?
Overall, looking much better! I still think we should do something different on the left hand menu -- maybe bring the historical trends stuff into the reports list, and put audit as its own menu item. Would I hold up putting this in because of that? No.
I had an earlier note about the reports that use inventory -- I have not checked those out in event world as of writing.
@awwaiid " Just noting that there is an inventory level on Itemized donations and itemized distributions -- with the moving parts we'll need to remember to check that with event source." -- Have those been eventized?
@cielf menu idea:
Move Inventory Audit into Inventory under Inventory Adjustment, still only shown to org-admin
Move each of the 3 "trend" reports alongside other reports of the same type
So overall collapsed menu looks like this:
Pre-existing problem noted -- if you have everything expanding, you can't scroll all the way to the bottom of the l.h.m.